Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[protos] Update the toolchain versions + remove patched tonic #15710

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

larry-aptos
Copy link
Contributor

@larry-aptos larry-aptos commented Jan 10, 2025

Description

^

How Has This Been Tested?

Rebuild protos and it works.

image

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify) protos

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Jan 10, 2025

⏱️ 1h 59m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / single-node-performance 30m 🟩🟥
check-dynamic-deps 21m 🟩🟩🟩🟩🟩 (+8 more)
rust-cargo-deny 20m 🟩🟩🟩 (+8 more)
test-target-determinator 9m 🟩🟩
execution-performance / test-target-determinator 8m 🟩🟩
rust-doc-tests 7m 🟩
rust-doc-tests 6m 🟩
general-lints 6m 🟩🟩🟩🟩🟩 (+8 more)
semgrep/ci 5m 🟩🟩🟩🟩🟩 (+8 more)
fetch-last-released-docker-image-tag 3m 🟩🟩
file_change_determinator 2m 🟩🟩🟩🟩🟩 (+8 more)
permission-check 36s 🟩🟩🟩🟩🟩 (+8 more)
permission-check 35s 🟩🟩🟩🟩🟩 (+8 more)
file_change_determinator 23s 🟩🟩
permission-check 5s 🟩🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
check-dynamic-deps 3m 1m +186%

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@larry-aptos larry-aptos marked this pull request as ready for review January 10, 2025 22:43
@larry-aptos larry-aptos force-pushed the 01-10-update_the_cli_versions branch from d4815e7 to f5c1a4d Compare January 10, 2025 22:43
@larry-aptos larry-aptos changed the title Update the CLI versions. [protos] Update the toolchain versions. Jan 10, 2025
@larry-aptos larry-aptos requested review from grao1991 and a team January 10, 2025 22:44
@larry-aptos larry-aptos force-pushed the 01-10-update_the_cli_versions branch 8 times, most recently from 22d815d to 2cf04c6 Compare January 11, 2025 01:59
@larry-aptos larry-aptos force-pushed the 01-10-update_the_cli_versions branch from 2cf04c6 to 3a705ed Compare January 11, 2025 02:01
@larry-aptos larry-aptos changed the title [protos] Update the toolchain versions. [protos] Update the toolchain versions + remove patched tonic Jan 11, 2025
@larry-aptos larry-aptos enabled auto-merge (squash) January 13, 2025 19:00

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@larry-aptos larry-aptos merged commit 6116af6 into main Jan 13, 2025
88 checks passed
@larry-aptos larry-aptos deleted the 01-10-update_the_cli_versions branch January 13, 2025 19:52

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on 6593fb81261f25490ffddc2252a861c994234c2a ==> 3a705eda23b4abcf707c4f3dc7a215396f395c75

Compatibility test results for 6593fb81261f25490ffddc2252a861c994234c2a ==> 3a705eda23b4abcf707c4f3dc7a215396f395c75 (PR)
1. Check liveness of validators at old version: 6593fb81261f25490ffddc2252a861c994234c2a
compatibility::simple-validator-upgrade::liveness-check : committed: 15494.56 txn/s, latency: 2230.71 ms, (p50: 1600 ms, p70: 1800, p90: 2700 ms, p99: 21000 ms), latency samples: 502660
2. Upgrading first Validator to new version: 3a705eda23b4abcf707c4f3dc7a215396f395c75
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 8010.60 txn/s, latency: 3728.75 ms, (p50: 4300 ms, p70: 4500, p90: 5000 ms, p99: 5100 ms), latency samples: 144140
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7997.94 txn/s, latency: 4194.95 ms, (p50: 4500 ms, p70: 4700, p90: 4900 ms, p99: 5000 ms), latency samples: 266980
3. Upgrading rest of first batch to new version: 3a705eda23b4abcf707c4f3dc7a215396f395c75
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7235.19 txn/s, latency: 3974.85 ms, (p50: 4200 ms, p70: 4800, p90: 5900 ms, p99: 6100 ms), latency samples: 128700
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7931.99 txn/s, latency: 4235.49 ms, (p50: 4600 ms, p70: 4700, p90: 4800 ms, p99: 4800 ms), latency samples: 264620
4. upgrading second batch to new version: 3a705eda23b4abcf707c4f3dc7a215396f395c75
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11692.74 txn/s, latency: 2506.84 ms, (p50: 2800 ms, p70: 3000, p90: 3200 ms, p99: 3200 ms), latency samples: 207100
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10929.88 txn/s, latency: 2998.18 ms, (p50: 3100 ms, p70: 3200, p90: 3500 ms, p99: 3700 ms), latency samples: 361800
5. check swarm health
Compatibility test for 6593fb81261f25490ffddc2252a861c994234c2a ==> 3a705eda23b4abcf707c4f3dc7a215396f395c75 passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 3a705eda23b4abcf707c4f3dc7a215396f395c75

two traffics test: inner traffic : committed: 15140.66 txn/s, latency: 2623.49 ms, (p50: 2700 ms, p70: 2700, p90: 2700 ms, p99: 3000 ms), latency samples: 5756840
two traffics test : committed: 99.98 txn/s, latency: 1346.30 ms, (p50: 1300 ms, p70: 1400, p90: 1400 ms, p99: 1600 ms), latency samples: 1780
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.506, avg: 1.483", "ConsensusProposalToOrdered: max: 0.286, avg: 0.284", "ConsensusOrderedToCommit: max: 0.298, avg: 0.290", "ConsensusProposalToCommit: max: 0.582, avg: 0.574"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.51s no progress at version 553 (avg 0.19s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.53s no progress at version 2340014 (avg 0.53s) [limit 16].
Test Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants