-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make compression encoding configuration more malleable #1757
Conversation
f2b257e
to
d11f97e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I feel the design and implementation is readable and extensible. I commented on small points.
Not completely sure whether this actually solves the original issue described in #1727. IMO it would be better if the config wrapper allowed overwriting the |
Motivation
Alternative approach to #1727, enable callers to influence compression encoding priority. Also changes the default order so that
Zstd
comes beforeGzip
if enabled (which happens when thezstd
Cargo feature is explicitly enabled).Solution
Implement an internal array while avoiding making changes to existing public API.
cc @CapCap