fix(checks): AVD-AWS-0034 enhanced container insights

[MichaelFoleyFZ]

Replaces the current ContainerInsightsEnabled boolean attribute on the ECS cluster settings with ContainerInsightsMode. Container Insights now supports three possible values, enabled, disabled and enhanced (https://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_ClusterSetting.html)

The enhanced mode is what is recommended by AWS now to get further metrics and details but has been separted from enable/disable due to its cost.

[CLAassistant]

All committers have signed the CLA.

[simar7]

Hmm interesting. So what happens to the old value, was it deprecated?

[MichaelFoleyFZ]

Hmm interesting. So what happens to the old value, was it deprecated?

So the containerInsights setting in the api was always a string but it was just enabled/disabled so fit with being setup as a binary value.

But to add enhanced container insights AWS just added a third possible string value enhanced to the same containerInsights setting

In the case of trivy I removed the old value as I wasn't sure what the stance was on a change like that.

[nikpivkin]

Hi @MichaelFoleyFZ !

The rule still checks that Container Insights is disabled. So can't we therefore process the string value on the Trivy side and export only the boolean value?

[MichaelFoleyFZ]

Will swap the sledge hammer for a screw driver