Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misconf)!: Add AWS ECS Enhanced Container Insights #8320

Conversation

MichaelFoleyFZ
Copy link
Contributor

@MichaelFoleyFZ MichaelFoleyFZ commented Jan 30, 2025

Description

Replaces the current ContainerInsightsEnabled boolean attribute on the ECS cluster settings with ContainerInsightsMode. Container Insights now supports three possible values, enabled, disabled and enhanced (https://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_ClusterSetting.html)

The enhanced mode is what is recommended by AWS now to get further metrics and details but has been separted from enable/disable due to its cost.

Related issues

  • Haven't raised an issue but did check to see if one existed

Related PRs

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@CLAassistant
Copy link

CLAassistant commented Jan 30, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@MichaelFoleyFZ MichaelFoleyFZ changed the title fix(misconfig)!: Add AWS ECS Enhanced Container Insights fix(misconf)!: Add AWS ECS Enhanced Container Insights Jan 30, 2025
@MichaelFoleyFZ MichaelFoleyFZ force-pushed the ecs-container-insights-enhanced branch from 8bf19ad to c5937f0 Compare January 30, 2025 23:12
@nikpivkin
Copy link
Contributor

Hi @MichaelFoleyFZ! Thanks for your contribution.

We can set ContainerInsightsEnabled when the setting value is enhanced or enabled. This will avoid schema changes, since the AVD-AWS-0034 check only checks that Container Insights is disabled.

@MichaelFoleyFZ
Copy link
Contributor Author

Will swap the sledge hammer for a screw driver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants