Fix: update dependency packages #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otms61
commented
Aug 31, 2023
Comment on lines
-259
to
-262
| if e, ok := err.(*transport.Error); ok && e.StatusCode == 404 { | ||
| // If the OCI registry returns 404, process it as an index with no referrer. This happens when the OCI registry does not support | ||
| // the referrers API. | ||
| index = &v1.IndexManifest{} |
There was a problem hiding this comment.
This code was originally implemented to avoid a past bug, and is no longer necessary.
The original API now returns an empty IndexManifest as well.
This issue has been fixed in this PR.
Comment on lines
-54
to
-58
| if e, ok := err.(*transport.Error); ok && e.StatusCode == 404 { | ||
| // If the OCI registry returns 404, process it as an index with no referrer. This happens when the OCI registry does not support | ||
| // the referrers API. | ||
| return nil | ||
| } |
There was a problem hiding this comment.
The issue has been resolved in the same PR as mentioned above: Related PR
This code was originally implemented to avoid a past bug, and is no longer necessary.
The original API now returns an empty IndexManifest as well.
knqyf263
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #17
This PR addresses the following updates:
remote.Referrers: Related PRIn the latest commit, functionality has been checked using the following command.