-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change return type of remote.Referrers #1652
Conversation
Actually using this was cumbersome because it just returns a struct. This is a breaking change, but I don't think it's a huge deal because not too many people should be using this yet (and we're < 1.0.0).
cc @jdolitsky |
What methods did you find yourself needing from the interface that you didn't get from the struct? |
E.g. if I want to save referrers to an OCI layout, I can just do that with a |
Makes sense, thanks for that example. |
Codecov Report
@@ Coverage Diff @@
## main #1652 +/- ##
==========================================
- Coverage 72.19% 72.11% -0.09%
==========================================
Files 120 120
Lines 9771 9782 +11
==========================================
Hits 7054 7054
- Misses 2002 2009 +7
- Partials 715 719 +4
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gotta make sure to update in cosign! I can do
Actually using this was cumbersome because it just returns a struct. This is a breaking change, but I don't think it's a huge deal because not too many people should be using this yet (and we're < 1.0.0).