Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add test:FixturePackageData target to generate Go fixtures #5553

Closed
wants to merge 2 commits into from

Conversation

lebauce
Copy link
Contributor

@lebauce lebauce commented Nov 10, 2023

Description

Adding a field to the types.Package - such as InstalledFiles require some tests
to be updated by modifying the Go structure used to compare against the results.
This PR has a mage target to automatically generate these Go structures.

Related issues

  • Close #XXX

Related PRs

  • #XXX
  • #YYY

Remove this section if you don't have related PRs.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@lebauce lebauce requested a review from knqyf263 as a code owner November 10, 2023 10:17
@lebauce lebauce marked this pull request as draft November 10, 2023 11:14
@lebauce
Copy link
Contributor Author

lebauce commented Nov 10, 2023

Waiting for #5488 to be merged first

@knqyf263
Copy link
Collaborator

knqyf263 commented Nov 16, 2023

Thanks for your great work. It looks awesome, but this sort of test should be covered by integration tests or E2E tests in the first place. I've replaced the test with the mock in this PR, and then this change is no longer needed. But thanks again for your effort.

@knqyf263 knqyf263 closed this Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants