-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: set InstalledFiles for DEB and RPM packages #5488
Conversation
9e7a267
to
1839501
Compare
@lebauce Thanks for your contribution! It looks like WIP. I converted it to a draft. Please let us know when it is ready for review. |
@knqyf263 No problem. The feature itself should work but I'm struggling with updating the fixtures of integration tests. Working on it |
68f01b5
to
fffe339
Compare
@knqyf263 I fixed the tests and undrafted the PR |
pkg/fanal/analyzer/analyzer.go
Outdated
@@ -146,6 +146,7 @@ type PostAnalysisInput struct { | |||
type AnalysisOptions struct { | |||
Offline bool | |||
FileChecksum bool | |||
CollectFiles bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can collect the files by default. I mean we may not need the option. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I updated the PR without the option
5e3eb4a
to
38eef9d
Compare
38eef9d
to
5cd93db
Compare
Thanks for updating the tests, but a massive list of expected values is not our intention. I created a PR to improve the RPM tests. I'll create a PR improving VM tests as well. After that, we can add better tests to this PR. |
Signed-off-by: knqyf263 <knqyf263@gmail.com>
Description
This PR does 2 main things :
Package
structure. This PR does the same for DEB and RPM.Related issues
Related PRs
Remove this section if you don't have related PRs.
Checklist