Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: mock RPM DB #5567

Merged
merged 2 commits into from
Nov 15, 2023
Merged

test: mock RPM DB #5567

merged 2 commits into from
Nov 15, 2023

Conversation

knqyf263
Copy link
Collaborator

Description

The current test for RPM uses a real file and is like a snapshot test. go-rpmdb is well-tested in it, and it is not necessarily tested in Trivy. Also, it can be covered in integration tests. The rpm tests should focus on the logic implemented in Trivy. This PR mocks the RPM DB for testing to define the expected packages easily.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@knqyf263
test(rpm): mock RPM DB
ee01917 
Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263 knqyf263 self-assigned this Nov 14, 2023
@knqyf263 knqyf263 changed the title test(rpm): mock RPM DB test: mock RPM DB Nov 14, 2023
@knqyf263 knqyf263 mentioned this pull request Nov 14, 2023
Merged
8 tasks
@knqyf263
Copy link
Collaborator Author

Error: stream error: stream ID 91; PROTOCOL_ERROR; received from peer

GHCR seems unstable...

@knqyf263
fix(rpm): use slash separator
d1283be 
Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263 knqyf263 marked this pull request as ready for review November 14, 2023 07:46
DmitriyLewen
DmitriyLewen approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knqyf263 knqyf263 added this pull request to the merge queue Nov 15, 2023
Merged via the queue into aquasecurity:main with commit d005f5a Nov 15, 2023
12 checks passed
@knqyf263 knqyf263 deleted the mock_rpmdb branch November 15, 2023 03:30
@knqyf263 knqyf263 mentioned this pull request Nov 15, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmitriyLewen DmitriyLewen DmitriyLewen approved these changes

Assignees

@knqyf263 knqyf263

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knqyf263 @DmitriyLewen