KernelProxy: emit SetApp event on construction #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
izqui
approved these changes
Nov 27, 2018
bingen
approved these changes
Dec 11, 2018
test/helpers/decodeEvent.js
Outdated
| const abi = require('web3-eth-abi') | ||
|
|
||
| module.exports = { | ||
| decodeEventsOfType: (receipt, eventAbi) => { |
There was a problem hiding this comment.
Wow, this is really nice! Way better than what I was doing here. I wonder if we could put it under @aragon/test-helpers or some other place which makes it easy for reuse.
I also think it may be nice to add a wrapper with abi.filter(abi => abi.name === eventName && abi.type === 'event')[0], so just passing the receipt, the global abi and the event name is enough.
There was a problem hiding this comment.
Yes... we should migrate to @aragon/test-helpers :D.
Will change the API to take in the abi too.
Merged
sohkai
added a commit
that referenced
this pull request
Mar 8, 2019
Allows a frontend to follow all `SetApp()` events emitted from the start of a KernelProxy's lifespan.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #457 by allowing a frontend to follow all
SetApp()events emitted from the start of a KernelProxy's lifespan.