Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release aragonOS 4.1.0 #475

Merged
merged 14 commits into from
Mar 8, 2019
Merged

Release aragonOS 4.1.0 #475

merged 14 commits into from
Mar 8, 2019

Conversation

sohkai
Copy link
Contributor

@sohkai sohkai commented Feb 11, 2019

Bytecode diff:

                              CODE DEPOSIT COST    DEPLOYED BYTES     INITIALIZATION BYTES
ACL.json                      123200 more gas      +616               0
APMRegistry.json              127200 more gas      +636               0
APMRegistryFactoryMock.json   356400 less gas      -1782              -49
AragonApp.json                123400 more gas      +617               0
DAOFactory.json               17000 more gas       +85                0
ENSSubdomainRegistrar.json    123400 more gas      +617               0
EVMScriptRegistry.json        123400 more gas      +617               0
EVMScriptRegistryFactory.json 935400 less gas      -4677              +617
Kernel.json                   126200 more gas      +631               0
KernelProxy.json              Same                 0                  +85
Repo.json                     123400 more gas      +617               0
TestACLInterpreter.json       123200 more gas      +616               0
TokenMock.json                202400 more gas      +1012              +13

Allows a frontend to follow all `SetApp()` events emitted from the start of a KernelProxy's lifespan.
* APMRegistry: fix tests checking APMRegistry doesn't init without required permissions

* EVMScriptRegistry: add more tests for coverage

* ENSSubdomainRegistrary: fix initialization test
@coveralls
Copy link

coveralls commented Feb 12, 2019

Coverage Status

Coverage increased (+0.8%) to 99.54% when pulling 37f8eff on dev into 5af5b84 on master.

@izqui
Copy link
Contributor

izqui commented Feb 12, 2019

Is this the PR security partners will look at before merging?

@izqui
Copy link
Contributor

izqui commented Feb 12, 2019

Also let's make sure we don't squash this branch when merging

@sohkai
Copy link
Contributor Author

sohkai commented Feb 12, 2019

@izqui Yes, this is.

Will be doing a normal merge with this (trying to figure out how to do a proper rebase and fast-forward merge on next afterwards on this repo, but last time I couldn't :/).

Copy link
Contributor

@bingen bingen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!


module.exports = {
decodeEventsOfType: (receipt, contractAbi, eventName) => {
const eventAbi = contractAbi.filter(abi => abi.name === eventName && abi.type === 'event')[0]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of abi here is a little bit confusing with the global variable to me. But no big deal, and sorry I didn't raise it when I reviewed #466, so let's leave it this way.

@bingen bingen self-requested a review February 25, 2019 14:22
@sohkai sohkai merged commit 68b651e into master Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants