-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release aragonOS 4.1.0 #475
Conversation
Allows a frontend to follow all `SetApp()` events emitted from the start of a KernelProxy's lifespan.
* APMRegistry: fix tests checking APMRegistry doesn't init without required permissions * EVMScriptRegistry: add more tests for coverage * ENSSubdomainRegistrary: fix initialization test
Is this the PR security partners will look at before merging? |
Also let's make sure we don't squash this branch when merging |
@izqui Yes, this is. Will be doing a normal merge with this (trying to figure out how to do a proper rebase and fast-forward merge on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
||
module.exports = { | ||
decodeEventsOfType: (receipt, contractAbi, eventName) => { | ||
const eventAbi = contractAbi.filter(abi => abi.name === eventName && abi.type === 'event')[0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use of abi
here is a little bit confusing with the global variable to me. But no big deal, and sorry I didn't raise it when I reviewed #466, so let's leave it this way.
Bytecode diff: