-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
integrate api workspaces #81
Conversation
# Conflicts: # frontend/package.json # frontend/yarn.lock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have noted the points raised. Please confirm.
ed400d7
to
4dcc382
Compare
…ulfilled to slice workspace
@sanglevinh
It seems that the above user_id is being removed on the API side in commit 0bec77a, but is the above error occurring in your environment? |
I reverted it
|
) | ||
data = paginate(db, query) | ||
for ws in data.items: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@quanpython
Could you refactor the models?
(In other PR can be OK)
It seems relationship and FK is not defined in current models.
FYI
https://docs.sqlalchemy.org/en/20/orm/basic_relationships.html#one-to-many
I don't think we have to insert User object into Workspace object like this process.
With relation, we can get User Object from user attribute.
6f77eb4
to
84d7fa9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backend requires refactor( as this comment), but frontend looks fine.
No description provided.