Sort (in python) the mechanism names (for convenience). #1882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The bug report states that order is not preserved when a catalog is assigned. This PR sorts them, which is not the same as preserving order. Maybe the bug reporter no longer requires this? |
|
The original bug did not require the order to be preserved pre-bugfix/post-bugfix, but rather just throughout the lifetime of where one assumed to be using the same catalogue object (i.e. after assigning the object somewhere, even if C++ creates a copy, it should not change behavior). So this fix is sufficient, as assigning it to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return mechanism names in sorted order.
Fixes #1879