Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort (in python) the mechanism names (for convenience). #1882

Merged
merged 1 commit into from
Apr 26, 2022
Merged

Sort (in python) the mechanism names (for convenience). #1882

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion python/mechanism.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,9 @@ void register_mechanisms(pybind11::module& m) {
pybind11::class_<arb::mechanism_catalogue> cat(m, "catalogue");

struct mech_cat_iter_state {
mech_cat_iter_state(const arb::mechanism_catalogue &cat_, pybind11::object ref_): names(cat_.mechanism_names()), ref(ref_), cat(cat_) { }
mech_cat_iter_state(const arb::mechanism_catalogue &cat_, pybind11::object ref_): names(cat_.mechanism_names()), ref(ref_), cat(cat_) {
std::sort(names.begin(), names.end());
}
std::vector<std::string> names; // cache the names else these will be allocated multiple times
pybind11::object ref; // keep a reference to cat lest it dies while we iterate
const arb::mechanism_catalogue& cat; // to query the C++ object
Expand Down