Add support for ignoredDependencies (Node.js only)
#179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should add, I really struggled to grep where to place this in the unit tests. I think it makes sense to add a new function to the example app which requires a new module, which would then mean the existing tests will check it only contains the previous expected one and not the additional new one...? |
|
Here's an attempt at adding a new function to the mock to exercise the https://github.com/andybee/hydrate/commit/aa0041a6dab5e1f51fda23ab838900bdb8763f36 |
|
Realised I was missing the expected module: https://github.com/andybee/hydrate/commit/98cef03580d6f88c6c2f162e8253aad432261fbb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See architect/architect#1458 for details.