Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignored dependencies #66

Closed
wants to merge 2 commits into from
Closed

Ignored dependencies #66

wants to merge 2 commits into from

Conversation

andybee
Copy link

@andybee andybee commented Oct 15, 2023 •
edited
Loading

See architect/architect#1458 for details.

@andybee andybee mentioned this pull request Oct 15, 2023
Closed
@ryanblock
Copy link
Member

ryanblock commented Oct 23, 2023 •
edited
Loading

Ok, thanks for your patience, I finally had a chance to look at this!

I think the ignoredDependencies implementation should be similar to how we do provisionedConcurrency, which is to say that since it's not a special case, function config upsert method should just allow this setting to pass through.

In this case, since it's a vector or array (which we don't yet support), I've added support in #67, which supersedes this PR.

From an implementation perspective, this should have no impact on architect/hydrate#179.

@ryanblock ryanblock closed this Oct 23, 2023
@andybee andybee deleted the ignored-dependencies branch October 27, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andybee @ryanblock