Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ant.yml #11988

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update ant.yml #11988

wants to merge 1 commit into from

Conversation

VarshiniShreeV
Copy link
Contributor

Version deprecation resolved

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes

I updated the upload-artifact action from v1 to v3 to address the deprecation notice issued by GitHub. Using the latest version is essential for maintaining the reliability and security of our CI/CD workflows.

Reasons for the Change:
Deprecation: The v1 version is deprecated and may no longer receive updates or support, which could lead to potential issues in our workflow.
Improved Functionality: The latest version includes enhancements and bug fixes that improve performance and reliability.
Security: Keeping dependencies updated helps protect against vulnerabilities and ensures that we are using the most secure version available.
Compatibility: The newer version is more compatible with other actions and features in GitHub Actions, reducing the risk of future compatibility issues.
By making this change, we ensure our workflow remains efficient and up to date with the latest best practices.

Version deprecation resolved
@@ -26,7 +26,7 @@ jobs:
working-directory: ./app
run: xvfb-run --auto-servernum --server-args "-screen 0 1024x768x24" ant test -Drunning-from-github-action=1
- name: Publish results
uses: actions/upload-artifact@v1
uses: actions/upload-artifact@v3 # Updated from v1 to v3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uses: actions/upload-artifact@v3 # Updated from v1 to v3
uses: actions/upload-artifact@v3

Don't pollute the file with worthless changelog comments. That what we have Git for!!!

It is ridiculous that you made the effort to add this comment, but you didn't make the effort to write a proper Git commit message. Step up your game @VarshiniShreeV.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your feedback on the change I made. I appreciate your perspective on keeping the file clean and utilizing Git for tracking changes.

I’ll make sure to improve my commit messages in the future to provide clearer context for the changes made. Your input helps me grow, and I’ll take it into account moving forward.

@per1234 per1234 self-assigned this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants