Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ant.yml #11988

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update ant.yml #11988

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ant.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
working-directory: ./app
run: xvfb-run --auto-servernum --server-args "-screen 0 1024x768x24" ant test -Drunning-from-github-action=1
- name: Publish results
uses: actions/upload-artifact@v1
uses: actions/upload-artifact@v3 # Updated from v1 to v3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uses: actions/upload-artifact@v3 # Updated from v1 to v3
uses: actions/upload-artifact@v3

Don't pollute the file with worthless changelog comments. That what we have Git for!!!

It is ridiculous that you made the effort to add this comment, but you didn't make the effort to write a proper Git commit message. Step up your game @VarshiniShreeV.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your feedback on the change I made. I appreciate your perspective on keeping the file clean and utilizing Git for tracking changes.

I’ll make sure to improve my commit messages in the future to provide clearer context for the changes made. Your input helps me grow, and I’ll take it into account moving forward.

with:
name: html-results
path: app/test-bin/results/html/
Expand Down
Loading