Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync issue when host sends multiple signon requests #8133

Closed
wants to merge 3 commits into from
Closed

Sync issue when host sends multiple signon requests #8133

wants to merge 3 commits into from

Conversation

f34rdotcom
Copy link

If the host sends a signon but does not get a SYNC response it will send again. This will lead to being out of sync with data in the rx buffer that is not consumed. To avoid this we consume all extra host bytes before sending a INSYNC reply.

@f34rdotcom
Sync issue when host sends multiple signon requests
4d469a6 
If the host sends a signon but does not get a SYNC response it will send again. This will lead to being out of sync with data in the rx buffer that is not consumed. To avoid this we consume all extra host bytes before sending a INSYNC reply.
per1234
per1234 requested changes Oct 25, 2018
View reviewed changes
Copy link
Collaborator

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the Arduino IDE's Tools > Auto Format feature so that your edits will be consistent with the style established by the rest of the file and all other built-in example sketches.

build/shared/examples/11.ArduinoISP/ArduinoISP/ArduinoISP.ino Outdated Show resolved Hide resolved
build/shared/examples/11.ArduinoISP/ArduinoISP/ArduinoISP.ino Outdated Show resolved Hide resolved
per1234 and others added 2 commits October 25, 2018 20:02
@f34rdotcom
Copy link
Author

Thanks for the review appreciate the feedback.
Best
SM

@facchinm facchinm added the Examples: ArduinoISP The ArduinoISP example sketch label Dec 13, 2018
@per1234 per1234 mentioned this pull request Sep 26, 2020
Open
@per1234
Copy link
Collaborator

per1234 commented Sep 26, 2020

Moved to arduino/arduino-examples#16

@per1234 per1234 closed this Sep 26, 2020
@per1234 per1234 added the Component: Documentation Related to Arduino's documentation content label Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

Assignees
No one assigned
Labels
Component: Documentation Related to Arduino's documentation content Examples: ArduinoISP The ArduinoISP example sketch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@f34rdotcom @per1234 @facchinm