Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync issue when host sends multiple signon requests #16

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Sep 26, 2020

Moved from arduino/Arduino#8133 by @f34rdotcom

If the host sends a signon but does not get a SYNC response it will send again. This will lead to being out of sync with data in the rx buffer that is not consumed. To avoid this we consume all extra host bytes before sending a INSYNC reply.

f34rdotcom and others added 3 commits September 25, 2020 19:08
If the host sends a signon but does not get a SYNC response it will send again. This will lead to being out of sync with data in the rx buffer that is not consumed. To avoid this we consume all extra host bytes before sending a INSYNC reply.
@f34rdotcom
Copy link

I am not sure how I can set my git repo back to that point so I can fix it :(
The fix is simple just need the {}. help :)

@per1234
Copy link
Contributor Author

per1234 commented Sep 26, 2020

I have now fixed the formatting @f34rdotcom. I appreciate your interest in getting the CI status to ✔️!

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ per1234
❌ f34rdotcom
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants