Skip to content

Make sure LED is not lit on sketch start #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

bigdinotech
Copy link
Contributor

-The LED retains the last state it was in after a sketch upload
-We need to make sure its is not lit on sketch startup so that behavior
is consistent

-The LED retains the last state it was in after a sketch upload
-We need to make sure its is not lit on sketch startup so that behavior
is consistent
@bigdinotech
Copy link
Contributor Author

bigdinotech commented Mar 16, 2017

@SidLeung @eriknyquist ready for review
Fixes #473

@eriknyquist eriknyquist added this to the Elnath milestone Mar 16, 2017
@SidLeung SidLeung assigned russmcinnis and noelpaz and unassigned bigdinotech Mar 16, 2017
@SidLeung
Copy link
Contributor

@russmcinnis , @noelpaz , please perform system testing.

@bigdinotech
Copy link
Contributor Author

2daed47

@sandeepmistry
Copy link
Contributor

@bigdinotech nice!

Are all the pins in input mode on sketch start? That's the default behaviour of AVR boards like the Uno and we should aim for the same for the 101.

For example, the SAMD core for boards like the Zero and MKR1000 has the following:

  // Setup all pins (digital and analog) in INPUT mode (default is nothing)
  for (uint32_t ul = 0 ; ul < NUM_DIGITAL_PINS ; ul++ )
  {
    pinMode( ul, INPUT ) ;
  }

https://github.com/arduino/ArduinoCore-samd/blob/96745cd48d8232ed37ec03d3a71d510aa9410f38/cores/arduino/wiring.c#L83-L87

cc/ @cmaglie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants