Jira 895, Set all pins to INPUT on sketch startup #489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SidLeung @eriknyquist ready for review |
eriknyquist
approved these changes
Mar 21, 2017
SidLeung
changed the title
SidLeung
approved these changes
Mar 21, 2017
|
@russmcinnis @noelpaz , please perform system testing on this PR. Please note that this PR superseded the following PR, |
russmcinnis
reviewed
Mar 21, 2017
There was a problem hiding this comment.
I tested by using a sketch to set all pins as outputs and set the pins high. I then ran a sketch without calling pinMode() and did a digitalRead() of all pins giving them high and low states. The digitalRead() always matched the stimulus. So this looks good to me.
|
tested again with PR490(471, 477, 480, 484 and 489) passed system test and the pin stimulus test to prove all pins default to input. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.