Skip to content

[bl] Allowing USB VID customization #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 22, 2016

Conversation

aethaniel
Copy link
Contributor

This patch allows USB VID customization via the compiler command line:

See line #78 of Makefile:
CFLAGS_EXTRA?=-D__SAMD21G18A__ -DUSB_PID_HIGH=0x00 -DUSB_PID_LOW=0x4D -DUSB_VID_LOW=0x41 -DUSB_VID_HIGH=0x23

I have added two more macros in order to have bootloaders ported on non-Arduino boards
These macros are used in sam_ba_usb.c in descriptor initialization, same way as for USB PID previously done.

Signed-off-by: Thibaut VIARD aethaniel@sam-geek.org

Signed-off-by: Thibaut VIARD <aethaniel@sam-geek.org>
Signed-off-by: Thibaut VIARD <aethaniel@sam-geek.org>
aethaniel added a commit to aethaniel/sme-arduino-core that referenced this pull request Dec 15, 2015
Signed-off-by: Thibaut VIARD <aethaniel@sam-geek.org>
@sandeepmistry
Copy link
Contributor

@aethaniel changes to define and use USB_PID_LOW and USB_VID_HIGH look good.

Are the updates to MODULE_PATH and T in the Makefile needed as well?

@aethaniel
Copy link
Contributor Author

Yes, everything is needed to match IDE v1.7
Thanks for reviewing
T.

On 21 January 2016 23:48:14 CET, Sandeep Mistry notifications@github.com wrote:

@aethaniel changes to define and use USB_PID_LOW and
USB_VID_HIGH look good.

Are the updates to MODULE_PATH and T in the Makefile needed
as well?


Reply to this email directly or view it on GitHub:
#72 (comment)

Envoyé de mon téléphone Android avec K-9 Mail. Excusez la brièveté.

@sandeepmistry sandeepmistry merged commit 75b71ab into arduino:master Jan 22, 2016
@sandeepmistry
Copy link
Contributor

Thanks, I think you mean't IDE 1.6.7 right?

I've merged and then removed the sections for IDE 1.6.5 in the Makefile (5f9b54b), as this core requires IDE 1.6.6 or later anyways.

@aethaniel
Copy link
Contributor Author

Yes, sorry for the typo, was indeed 1.6.7

On 22 January 2016 15:30:33 CET, Sandeep Mistry notifications@github.com wrote:

Thanks, I think you mean't IDE 1.6.7 right?

I've merged and then removed the sections for IDE 1.6.5 in the Makefile
(5f9b54b),
as this core requires IDE 1.6.6 or later anyways.


Reply to this email directly or view it on GitHub:
#72 (comment)

Envoyé de mon téléphone Android avec K-9 Mail. Excusez la brièveté.

@cmaglie cmaglie added this to the Release 1.6.3 milestone Jan 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants