add support for I2C repeated start, tested with MB85RC256V #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oops, already in #66 - well now you have 2 versions :D |
|
tried git@github.com:sandeepmistry/ArduinoCore-samd.git -b "wire-master-repeated-start" and it also works just fine with the MB85RC256V |
|
@ladyada great, thanks for trying it out! |
|
Fixed with #66 |
boseji
pushed a commit
to go-ut/combined-ArduinoCore-samd
that referenced
this pull request
May 30, 2020
This small change removes many of the warnings that are generated when compiling this core with warnings switched on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
repeated start on the atsamd21 is a little interesting, instead of telling the i2c master to send a REPEATED_START (which you would think is the thing to do) you should send no command. then, next time the ADDR is set, it will automatically do the repeated start for you.
See table 27-12 in datasheet:
_If CMD 0x1 is issued, a repeated start will be issued followed by the transmission of the current address in ADDR.ADDR. If another address is desired, ADDR.ADDR must be written instead of the CMD bits. This will trigger a repeated start followed by transmission of the new address._