Add Portenta X8 to compilation checks #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
requested changes
May 22, 2024
There was a problem hiding this comment.
As you reported at #74, any sketch that uses Serial won't compile for the Portenta X8. So the workflow must be configured to not compile those sketches for Portenta X8.
Please create a serial board attribute and move the sketches that use Serial from jobs.build.env.UNIVERSAL_SKETCH_PATHS to the newly created serial element in jobs.build.strategy.matrix.include[]
In case you don't know how this system works, I provided some explanation here:
per1234
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly closes #75