Skip to content

Conversation

aliphys
Copy link

@aliphys aliphys commented May 22, 2024

Partly closes #75

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please investigate the compilation failures.

In cases where the sketch is simply not compatible with the board, configure the workflow so that it won't compile the sketch for the Nicla Sense ME. See the review on the other PR for guidance on how to accomplish that.

If a compilation failure is caused by a deficiency in the sketch that can be resolved by either a change to the "Arduino Mbed OS Nicla Boards" core, or a change to the sketch that does not have a harmful effect on the approachability of the sketch for beginners, then it is OK to leave the workflow configured to compile the sketch. However, you should be prepared to take action to resolve the failure in the near future so that this PR doesn't result in the repository having a perpetually failing CI system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ACELL04] Include the Portenta X8 and Nicla Sense ME as part of the CI workflow
2 participants