Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ATL-1064: Support for nested sketchbook structure #198

Merged
merged 1 commit into from
Mar 11, 2021
Merged

ATL-1064: Support for nested sketchbook structure #198

merged 1 commit into from
Mar 11, 2021

Conversation

kittaakos
Copy link
Contributor

This PR adds support for sketchbook subfolders.

FS State:

Screen Shot 2021-03-10 at 17 28 23

Sketchbook menu:
Screen Shot 2021-03-10 at 17 27 39

Open context menu. libraries are there, just like in the Java IDE.
Screen Shot 2021-03-10 at 17 27 50

Note: This PR does not expand the examples node from the libraries.
Java IDE:
Screen Shot 2021-03-10 at 17 34 15

IDE 2:
Screen Shot 2021-03-10 at 17 35 01

Signed-off-by: Akos Kitta kittaakos@typefox.io

ATL-1064: Support for nested sketchbook structure
b699e3b 
Signed-off-by: Akos Kitta <kittaakos@typefox.io>
@kittaakos kittaakos requested a review from per1234 March 10, 2021 16:36
per1234
per1234 approved these changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it out and it's working just as expected from the classic Arduino IDE. Thanks Akos!

@kittaakos
Copy link
Contributor Author

Thank you for the review <3

@kittaakos kittaakos merged commit c64ac48 into main Mar 11, 2021
@kittaakos kittaakos deleted the atl-1064--subfolder-in-sketchbook branch March 11, 2021 09:32
@kittaakos kittaakos mentioned this pull request Mar 11, 2021
Closed
@silvanocerza silvanocerza mentioned this pull request Apr 6, 2021
Closed
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Oct 28, 2021
@drachezoil drachezoil mentioned this pull request Nov 8, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kittaakos @per1234