Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go.bug.st/relaxed-semver from 0.11.0 to 0.12.0 #645

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 24, 2023

Bumps go.bug.st/relaxed-semver from 0.11.0 to 0.12.0.

Release notes

Sourced from go.bug.st/relaxed-semver's releases.

Release v0.12.0

What's Changed

Full Changelog: bugst/relaxed-semver@v0.11.0...v0.12.0

Commits
  • b4bf3c6 Merge pull request #17 from bugst/performance
  • 391e859 Merge pull request #19 from bugst/templated_resolver
  • fee3392 Fixed another bug in comparator
  • 89efb15 Fixed JSON/YAML/Binary parsing
  • ae9c7ba coverage to 100% again
  • a325c52 Made Resolver state variables as fields
  • 00b3516 Simplified loop
  • 8711f89 Renamed Archive -> Resolver
  • 9f1049e Implemented dependency-templated resolver
  • e8b9735 Merge pull request #18 from bugst/go1.21
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the topic: infrastructure Related to project infrastructure label Nov 24, 2023
@per1234 per1234 self-assigned this Dec 4, 2023
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the errors exposed by the CI are caused by the go.bug.st/relaxed-semver module's use of features that are not available in the 1.17 version of Go currently used with this project. The module now specifies minimum compatibility of Go 1.21: bugst/relaxed-semver#18.

So merging of this PR must be put on hold until we are able to find time to update the project to using a newer version of Go.

@per1234 per1234 added the status: on hold Do not proceed at this time label Dec 7, 2023
@per1234 per1234 removed the status: on hold Do not proceed at this time label Nov 25, 2024
@per1234
Copy link
Contributor

per1234 commented Nov 25, 2024

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 25, 2024

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@per1234
Copy link
Contributor

per1234 commented Nov 25, 2024

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/go_modules/go.bug.st/relaxed-semver-0.12.0 branch from a3c12c7 to b1d10f1 Compare November 25, 2024 05:52
@per1234
Copy link
Contributor

per1234 commented Nov 25, 2024

@dependabot rebase

Bumps [go.bug.st/relaxed-semver](https://github.com/bugst/relaxed-semver) from 0.11.0 to 0.12.0.
- [Release notes](https://github.com/bugst/relaxed-semver/releases)
- [Commits](bugst/relaxed-semver@v0.11.0...v0.12.0)

---
updated-dependencies:
- dependency-name: go.bug.st/relaxed-semver
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/go.bug.st/relaxed-semver-0.12.0 branch from b1d10f1 to 2694b1a Compare November 25, 2024 07:13
The bump of the dependency of the project's root `github.com/arduino/arduino-lint` module also requires updates to the
Go dependencies metadata of the project's modules which depend on `github.com/arduino/arduino-lint`.
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous blocker of go.bug.st/relaxed-semver@v0.12.0 requiring a higher version of Go than used by this project has been resolved by #761.

Unfortunately there is an additional blocker, as revealed by task go:vet:

https://github.com/arduino/arduino-lint/actions/runs/12005234943/job/33461512685?pr=645#step:5:19

Error: ../../../go/pkg/mod/github.com/arduino/arduino-cli@v0.35.4-0.20241001142927-1f8d0f6c0dd3/arduino/libraries/librariesindex/index.go:151:28: cannot use generic type semver.Releases[R semver.Release[D], D semver.Dependency] without instantiation
Error: ../../../go/pkg/mod/github.com/arduino/arduino-cli@v0.35.4-0.20241001142927-1f8d0f6c0dd3/arduino/libraries/librariesindex/index.go:153:15: cannot use generic type semver.Releases[R semver.Release[D], D semver.Dependency] without instantiation
Error: ../../../go/pkg/mod/github.com/arduino/arduino-cli@v0.35.4-0.[20](https://github.com/arduino/arduino-lint/actions/runs/12005234943/job/33461512685?pr=645#step:5:21)241001142927-1f8d0f6c0dd3/arduino/libraries/librariesindex/index.go:161:21: undefined: semver.Archive
task: Failed to run task "go:vet": exit status 1
Error: Process completed with exit code 201.

So the v0.35.4-0.20241001142927-1f8d0f6c0dd3 version of the github.com/arduino/arduino-cli dependency is incompatible with go.bug.st/relaxed-semver@v0.12.0, due to breaking changes in the go.bug.st/relaxed-semver API. This means that the github.com/arduino/arduino-cli dependency must be bumped in tandem with the go.bug.st/relaxed-semver bump proposed here.

github.com/arduino/arduino-cli was updated to use the go.bug.st/relaxed-semver@v0.12.0 API in arduino/arduino-cli@0381aa5, which was released in github.com/arduino/arduino-cli@v1.0.0. Significant changes were introduced to the github.com/arduino/arduino-cli API in v1.0.0, which include making most of its packages internal. So significant changes to the Arduino Lint codebase are likely to be required in order to bump github.com/arduino/arduino-cli to >=v1.0.0.

@per1234 per1234 added type: enhancement Proposed improvement status: on hold Do not proceed at this time status: changes requested Changes to PR are required before merge and removed status: on hold Do not proceed at this time labels Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: changes requested Changes to PR are required before merge topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant