-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated arduino-cli to 0.35.x branch with a lot of libraries #761
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #761 +/- ##
==========================================
- Coverage 90.05% 89.97% -0.09%
==========================================
Files 44 44
Lines 6800 6772 -28
==========================================
- Hits 6124 6093 -31
- Misses 553 555 +2
- Partials 123 124 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
de93d49
to
48471b7
Compare
48471b7
to
07ead9b
Compare
I apologize for introducing merge conflicts for this PR in the workflows @cmaglie. I have a couple more changes to make in the workflows to get them fully up to date and I'll take care of rebasing the PR once those are done. I'm not touching any Go code or dependencies or integration tests. |
e736753
to
6c3caba
Compare
No worries, I've already rebased it, the changes were trivial. |
6c3caba
to
068d4ce
Compare
@per1234 I removed the checks for I want to add checks for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be updated:
Line 326 in 0e6248f
GO_VERSION: 1.17 |
The reason I did this is because I found that, without it, the project had a lot of unused transitive dependencies (for example, when I updated a direct module dependency and did a go mod tidy
, a former dependency of that direct dependency that was no longer used by the new version would be left behind in the go.mod+go.sum, and thus in the license metadata, even though it was no longer used by anything). Once I added the -compat=1.17
flag, go tidy
behaved exactly as I expected. Apparently the unexpected behavior was due to Go needing to do a suboptimal tidy in order to provide compatibility with certain other versions of Go, but we don't support the use of the project with versions of Go other than the one specified by the go
directive so that isn't of interest.
I don't know whether the -compat
flag is needed for proper tidy behavior with 1.22 though.
This needs to be updated:
arduino-lint/docs/CONTRIBUTING.md
Line 79 in 0e6248f
- [Go](https://golang.org/doc/install) version 1.17 or later |
Or we can merge #801 now and render it obsolete:
arduino-lint/docs/CONTRIBUTING.md
Lines 79 to 81 in be9eff0
- [Go](https://golang.org/doc/install | |
- The **Go** version in use is defined in the `go` directive of | |
[`go.mod`](https://github.com/arduino/arduino-lint/blob/main/go.mod). |
a177ea3
to
0c7f6cf
Compare
With the latest |
This brings the Arduino CLI integration up to 0.35.x branch (the latest before the big 1.0 break).
I've taken the chance to upgrade golang to 0.22.5 (we are still not supporting 0.23.0 in the Disttask.yml file).