Skip to content

Fixing node version and sync package lock #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 5, 2022
Merged

Fixing node version and sync package lock #26

merged 6 commits into from
Dec 5, 2022

Conversation

murilopolese
Copy link
Contributor

Addressing this issue: #16

  • Include engines.node on package.json
  • Upgrading node version to 16
  • Merging scripts and build_resources folder
  • Remove python2.7 dependency on GH Action
  • Updating action dependency versions to avoid building warnings

@CLAassistant
Copy link

CLAassistant commented Dec 1, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@murilopolese murilopolese requested a review from ubidefeo December 1, 2022 10:30
@murilopolese
Copy link
Contributor Author

Removed editor margin as requested by @ubidefeo ;)

ubidefeo
ubidefeo approved these changes Dec 5, 2022
View reviewed changes
Copy link
Collaborator

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@murilopolese murilopolese merged commit 53baad4 into main Dec 5, 2022
@per1234 per1234 mentioned this pull request Dec 5, 2022
Closed
@per1234 per1234 mentioned this pull request Dec 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ubidefeo ubidefeo ubidefeo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@murilopolese @CLAassistant @ubidefeo