Skip to content

Release Candidate v0.6 #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Dec 29, 2022
Merged

Release Candidate v0.6 #30

merged 13 commits into from
Dec 29, 2022

Conversation

murilopolese
Copy link
Contributor

Bugfixes:

  • Every user when first launching the editor and connecting a board, is confused by the terminal taking so much space and don’t understand they can resize it
  • When the board is connected, the word under the connect button should be disconnected
  • When a person clicks on disconnect it should not see the serial board list unless you click
  • Adjust file control button sizes
  • Refers to "serial" as "board" on confirmation prompts

Features:

  • UI app should be able to specify the electron app size constraint
  • Person should be able to confirm or deny file replacement/ovewrite/delete

@murilopolese murilopolese changed the title Release Candidate Release Candidate v0.6 Dec 20, 2022
Copy link
Collaborator

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it all looks good, thank you

@ubidefeo
Copy link
Collaborator

@murilopolese
I see this error in the CI, related to lockFileVersion.
Can you take a look?

Thank you
u.

Run # See: https://www.electron.build/code-signing
[190](https://github.com/arduino/lab-micropython-editor/actions/runs/3742033817/jobs/6352432884#step:4:191)
npm WARN read-shrinkwrap This version of npm is compatible with lockfileVersion@1, but package-lock.json was generated for lockfileVersion@2. I'll try to do my best with it!
[191](https://github.com/arduino/lab-micropython-editor/actions/runs/3742033817/jobs/6352432884#step:4:192)
npm ERR! cb() never called!
[192](https://github.com/arduino/lab-micropython-editor/actions/runs/3742033817/jobs/6352432884#step:4:193)

[193](https://github.com/arduino/lab-micropython-editor/actions/runs/3742033817/jobs/6352432884#step:4:194)
npm ERR! This is an error with npm itself. Please report this error at:
[194](https://github.com/arduino/lab-micropython-editor/actions/runs/3742033817/jobs/6352432884#step:4:195)
npm ERR!     <https://npm.community/>
[195](https://github.com/arduino/lab-micropython-editor/actions/runs/3742033817/jobs/6352432884#step:4:196)

[196](https://github.com/arduino/lab-micropython-editor/actions/runs/3742033817/jobs/6352432884#step:4:197)
npm ERR! A complete log of this run can be found in:
[197](https://github.com/arduino/lab-micropython-editor/actions/runs/3742033817/jobs/6352432884#step:4:198)
npm ERR!     /Users/runner/.npm/_logs/2022-12-20T15_59_16_107Z-debug.log
[198](https://github.com/arduino/lab-micropython-editor/actions/runs/3742033817/jobs/6352432884#step:4:199)
Error: Process completed with exit code 1.

@murilopolese
Copy link
Contributor Author

I think it's because I didn't rebuild my local develop branch. I'm on it.

@murilopolese
Copy link
Contributor Author

@ubidefeo fixed!

@per1234
Copy link
Collaborator

per1234 commented Dec 20, 2022

@murilopolese the error:

This version of npm is compatible with lockfileVersion@1, but package-lock.json was generated for lockfileVersion@2

is because the Node.js version used during the build was not actually updated by #26

This line must be changed:

Reference:

https://github.com/actions/setup-node#supported-version-syntax

@murilopolese murilopolese merged commit 0b84623 into main Dec 29, 2022
@per1234 per1234 deleted the develop branch June 28, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants