-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove TFLM from Arduino library download cache #1748
Conversation
Removed 'https://github.com/bcmi-labs/tensorflow_lite_mirror' from the list
Hi @wrighkv1. If you intended to submit a library, please check the instructions and update your pull request if necessary: |
Hi @wrighkv1. Although everyone is welcome to submit any library, changes to existing registry entries may only be done with the authorization of a maintainer of the library. Unfortunately, I was unable to verify that this request was authorized. Please provide proof that this request is authorized. Thanks! |
Hi per1234, Thanks for the quick response. I am a member of the TensorFlow Lite Micro team. We would like to remove this TFLM library from the Arduino library download cache. |
@per1234, how do we go about finding who the maintainer of the library is? The git history / blame for repositories.txt isn't letting me get to that information and the registry entry that we want to remove (https://github.com/bcmi-labs/tensorflow_lite_mirror) is not a valid repository. The TensorFlow Lite Micro team (of which both me and @wrighkv1 are members) is maintaining the library at https://github.com/tensorflow/tflite-micro-arduino-examples. In the current situation, the version of TfLite Micro that is available from the Library Manager is unclear to us. |
Arduino maintains this library (not the source code itself, but the packaging of TensorFlow Lite into a valid Arduino library). "bcmi-labs" is one of the GitHub organizations owned by Arduino.
It is a valid repository. It is only that it is a private repository. The only reason for it being private is to avoid wasting the time of contributors who might submit issues or pull requests for changes to the mirrored code, not understanding that those contributions must be made to the upstream repository. The contents of the repository are of course no secret, as they are publicly available from the Arduino Library Manager. But the Git data is removed from all the library packages in Library Manager for efficiency, so we do miss being able to take a look at the revision control history.
I apologize for any confusion. I will discuss this with the relevant people at Arduino. |
Hi @wrighkv1 and @advaitjain. Before proceeding with the requested removal, I would like to make sure you are fully aware of the implications: Loss of Library Manager installation optionThe library will be removed completely from the Arduino Library Manager index, which will break any tutorials, etc. which rely on this standard installation method. For example:
Loss of availability of Arduino's releasesIt might be challenging for those interested in using an existing project which pinned one of the releases of the library formerly distributed by Arduino to source that same version elsewhere, since The alternative will be for them to use a version of the library the project was not validated for. Arduino provides precompiled releases of the libraryArduino's packaging infrastructure for the library produces precompiled releases which dramatically reduce what would otherwise be a lengthy compilation time for the user's sketches that use the library. |
Thanks @ladyada! That "Allow forking" setting is very interesting to me for use in a couple other public mirror repositories:
Unfortunately, I looked into their settings and didn't see this "Allow forking" setting: I do see it in a private repository though. Was the screenshot you shared from a private repo? GitHub's docs seem to indicate the feature is for private repos: For preventing PRs, we are currently using the "Interaction Limits" setting. The only problem with this approach is it has a maximum period of 6 months, so we must remember to periodically cycle the setting to avoid it expiring. |
Thanks a lot for the detailed replies! After giving it some more thought we came to the conclusion that we would still like to continue with removing the library manager installation for Tensorflow Lite Micro. |
@wrighkv1 @advaitjain I am confirming your request. Unlike submissions, this type of request is still handled manually. The Library Manager index maintainer occasionally comes through to clear all the outstanding requests. They will merge this pull request when it is done. You will get a notification from GitHub at that time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done:
2022/08/31 16:21:41 Loaded 5121 libraries from DB
Removing Arduino_TensorFlowLite
warning: Library Git clone folder /home/ubuntu/workspace/gitclones/github.com/bcmi-labs/tensorflow_lite_mirror not present
Success!
Removed 'https://github.com/bcmi-labs/tensorflow_lite_mirror' from the list
Removing TFLM from Arduino library download cache.