Fix breakage from removal of Arduino_TensorFlowLite dependency from Library Manager #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibrary Manager The "Arduino_TensorFlowLite" library is a dependency of this project. This dependency was previously included in the Arduino Library Manager index, which was used by the project in the following ways: - Specified as dependency in metadata to provide automated installation along with TinyTrainable - Referenced by name alone in the library dependencies configuration of the "Arduino Compile" GitHub Actions workflow - Link to the generated library reference on arduino.cc The library was removed from the Arduino Library Manager index at the request of the TensorFlow Lite Micro maintainers, which broke all three of the usages listed above. That breakage is hereby repaired: All libraries listed in the `depends` field of the library.properties metadata file must be available for installation from Library Manager. The presence of Arduino_TensorFlowLite on that list causes the library installation to fail with Arduino IDE 2.x, or `arduino-cli lib install TinyTrainable`. The library is removed from the list. The configuration of the "Arduino Compile" GitHub Actions workflow is adjusted to install the library by cloning the official tensorflow/tflite-micro-arduino-examples library. Since that repository does not currently provide any tags, the workflow is configured to use the version of the library from the tip of the main branch. The readme is updated to specify that the Arduino_TensorFlowLite library must be installed manually, and the link updated from the obsolete generated reference page to the official repository for the library, which contains manual installation instructions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Arduino_TensorFlowLite" library is a dependency of this project.
This dependency was previously included in the Arduino Library Manager index, which was used by the project in the following ways:
The library was removed from the Arduino Library Manager index at the request of the TensorFlow Lite Micro maintainers (arduino/library-registry#1748), which broke all three of the usages listed above.
That breakage is hereby repaired:
Library metadata
All libraries listed in the
dependsfield of thelibrary.propertiesmetadata file must be available for installation from Library Manager. The presence ofArduino_TensorFlowLiteon that list causes the library installation to 'fail with Arduino IDE 2.x, orarduino-cli lib install TinyTrainable. The library is removed from the list.GitHub Actions workflow
The previous configuration of the "Arduino Compile" GitHub Actions workflow caused it to install the dependency from Library Manager, which will now result in a failure:
The workflow is here adjusted to install the library by cloning the official
tensorflow/tflite-micro-arduino-examplesrepository. Since that repository does not currently provide any tags, the workflow is configured to use the version of the library from the tip of the main branch.Note that the library does not compile with the version of the library from the tip of the main branch of the
tensorflow/tflite-micro-arduino-examplesrepository:The header file does not (and never did) exist in the version of the library from the
tensorflow/tflite-micro-arduino-examplesrepository:https://github.com/tensorflow/tflite-micro-arduino-examples/tree/main/src/tensorflow/lite
So this will need to be resolved by adjusting the TinyTrainable code, which is out of scope for this PR.
Documentation
The readme is updated to specify that the "Arduino_TensorFlowLite" library must be installed manually, and the link updated from the obsolete generated reference page to the official repository for the library, which contains manual installation instructions.