-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #25: Support ARM64 and other platforms #44
fix #25: Support ARM64 and other platforms #44
Conversation
Hmm, don't merge this, it doesn't properly detect these platforms yet. |
Actually, my test wasn't actually running on those weird platforms, it was using cross-compilation. I think setup-protoc should probably let users override |
@MatteoPologruto @per1234 Hi! Could I please get a review on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! Do you mind addressing the change requested? We'd really like to merge this 🤓
Co-authored-by: Alessio Perugini <alessioper.98@gmail.com>
Co-authored-by: per1234 <accounts@perglass.com>
Co-authored-by: per1234 <accounts@perglass.com>
Of course, I applied all suggestions. |
I can't get the |
Might be related to this:
should be:
|
OK, formatter fixed. BTW in your formatting example
those two are actually duplicates! So I deduplicated it. All tests pass now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Nice! I can't merge until @per1234 changes their review status, or an admin merges this for me. |
@adamchalmers we forgot to run |
Done, I got one error from
|
EDIT: Actually not needed as we're switching to ncc building. Thank you so much for your contribution! 🥇 |
Requests for changes correctly submitted. 💪
Awesome, thanks for shepherding this through, Alessio. |
I've added unit tests, so hopefully this works :) If you approve this PR I would appreciate cutting a new release afterwards, as there's a number of projects which would like to run this on ARM.