chore: Bump Prost to 0.11

[adamchalmers]

I noticed the Dependabot PRs (#89 #90 #92), but you really have to update all three Prost crates simultaneously because otherwise you'll get weird errors between versions. So, here's one PR to bump prost's family of crates.

[phyber]

Looks good to me.

[adamchalmers]

Looks good to me.

Thanks! As a first-time contributor, I can't merge yet, I'll need someone to allow CI jobs to run on this PR.

[mxinden]

@adamchalmers thanks for the patch. This is missing the protoc installation step. See additional commits on #92.

Unfortunately #92 is currently failing on armv7-unknown-linux-gnu. I am guessing due to cargo expecting an arm version of protoc. Haven't investigated enough. Help appreciated.

[adamchalmers]

Can do, let me see... El jue, 22 de sept de 2022, 10:22 a. m., Max Inden ***@***.***> escribió:

…

@adamchalmers <https://github.com/adamchalmers> thanks for the patch. This is missing the protoc installation step. See additional commits on #92 <#92>. Unfortunately #92 <#92> is currently failing on armv7-unknown-linux-gnu. I am guessing due to cargo expecting an arm version of protoc. Haven't investigated enough. Help appreciated. — Reply to this email directly, view it on GitHub <#98 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABJIFYITYSPDCGNSRO7NXMLV7R2SPANCNFSM6AAAAAAQSFLCLI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[adamchalmers]

@mxinden Can you pls grant me permission to run workflows? "First-time contributors need a maintainer to approve running workflows. Learn more."

[mxinden]

Approved on the latest changes. Is there a way to auto-approve your pull requests to run on CI? If not, I think you can just run the pipelines on your fork, right?

[adamchalmers]

Yeah, I can run them on my fork.

[adamchalmers]

I think the root cause is that the GH action for installing protoc doesn't support ARM. There's an issue open for ARM support: arduino/setup-protoc#25 -- notice that in the logs from this CI job, you can see it's downloading an x86-64 binary instead of an ARM binary.

Downloading archive: https://github.com/protocolbuffers/protobuf/releases/download/v3.20.2/protoc-3.20.2-linux-x86_64.zip

I think the erroneous line of their action is here:

const arch: string = osArch == "x64" ? "x86_64" : "x86_32";

So we'll need a PR to that repo to add ARM support, or fork it, or write our own action to install the arm target.

AFAICT prost isn't revealed to users, and it's not part of the public API for this crate. So upgrading to 0.11 isn't a big priority, and shouldn't block any other PRs/releases.

[mxinden]

Thanks @adamchalmers for your work on arduino/setup-protoc#25!

[adamchalmers]

My pleasure. I am a bit confused why we even need this action though -- can't we just install protoc from the package managers on windows/macos/ubuntu? Why do we need to install a particular version from GitHub release?

[adamchalmers]

OK, I opened a PR to fix the issue on the setup-protoc action. In the meantime, I switched to my fork of the action on this branch, so we can see if CI passes. @mxinden could you please approve running CI on this branch?

[mxinden]

@adamchalmers I triggered CI.

[adamchalmers]

Looks like it doesn't quite work yet. I'll do more testing in my personal fork and figure out why.

[adamchalmers]

So, the reason my PR to setup-protoc doesn't work: each of this project's 5 matrix jobs (named "Cross compile") are all actually running on Ubuntu x86_64. The various CPU architectures are only passed to the cargo build step, they don't actually affect the action runner. So the "install protoc" step correctly recognizes the environment as Linux x86_64.

I guess the solution is would have three parts:

1. setup-protoc needs another configurable input for target OS arch
2. The "Cross compile" job sets that input to ${{ matrix.target }}
3. Ensure that protoc gets used for the cross-compile

EDIT: The other problem is that the cross compile targets include three targets for which there is no protoc binary:

• mipsel-unknown-linux-gnu
• powerpc-unknown-linux-gnu
• armv7-unknown-linux-gnueabihf

I don't see any protoc releases for mipsel, and there's only 64-bit releases for powerpc and arm (but your target powerpc and arm7 are both 32-bit). So I guess using a static protoc for those architectures won't work.

Is it really important to test protocol buffer support on those architectures? If so, I guess we have to compile protoc from source. If not, maybe we just disable the protocol buffer feature on those architectures?

[mxinden]

Thanks for all the investigation @adamchalmers.

Is it really important to test protocol buffer support on those architectures?

I think it is a nice-to-have. In other words, I am fine with not testing the protobuf feature on these platforms for now.

[adamchalmers]

No worries! I'm a little disappointed I couldn't get it all to work how I wanted, but at least I learned a lot about GitHub actions along the way. Finally, this PR passes all the CI.

[mxinden]

Again, thank you for your help here @adamchalmers.