Skip to content

Fix pull request closure UI update #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
areibman wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix pull request closure UI update #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions src/renderer/components/PRTreeView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,14 +421,16 @@ export function PRTreeView({
onClick={(event) => {
event.stopPropagation();
onCloseGroup(item.data.closablePRIds ?? []);
setHoveredGroup(null);
// Don't immediately clear hover - let the UI update be visible
setTimeout(() => setHoveredGroup(null), 500);
}}
onKeyDown={(event) => {
if (event.key === 'Enter' || event.key === ' ') {
event.preventDefault();
event.stopPropagation();
onCloseGroup(item.data.closablePRIds ?? []);
setHoveredGroup(null);
// Don't immediately clear hover - let the UI update be visible
setTimeout(() => setHoveredGroup(null), 500);
}
}}
className={cn(
Expand Down
7 changes: 5 additions & 2 deletions src/renderer/views/PRListView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,8 +526,11 @@ export default function PRListView() {
const handleCloseGroup = useCallback(
async (prIds: string[]) => {
await closePRIds(prIds);
// Force a re-render by updating the filter state
// This ensures the UI updates immediately after closing PRs
setPRListFilters(prev => ({ ...prev }));
},
[closePRIds],
[closePRIds, setPRListFilters],
);

const hasSelection = selectedPRs.size > 0;
Expand Down Expand Up @@ -911,7 +914,7 @@ export default function PRListView() {
</div>
) : (
<PRTreeView
key={`${Array.from(selectedStatuses).join('-')}-${Array.from(selectedAuthors).join('-')}`}
key={`${Array.from(selectedStatuses).join('-')}-${Array.from(selectedAuthors).join('-')}-${prsWithMetadata.filter(p => p.pr.state === 'open').length}-${prsWithMetadata.filter(p => p.pr.state === 'closed').length}`}
theme={theme}
prsWithMetadata={prsWithMetadata}
selectedPRs={selectedPRs}
Expand Down