Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bridge Mitsubishi AC devices to Homebridge/Homekit locally #22236

Merged
merged 10 commits into from
Oct 5, 2024
Merged

Bridge Mitsubishi AC devices to Homebridge/Homekit locally #22236

merged 10 commits into from
Oct 5, 2024

Conversation

grzegorz914
Copy link
Contributor

@grzegorz914 grzegorz914 commented Oct 3, 2024 •
edited
Loading

Description:

  • code structure cleanup.
  • added Power, SetTemperature, Mode, SwingV, SwingH, FanSpeed to the JSON Object StatusSNS.MiElHVAC
    This changes will be used with upcoming update for homebridge-tasmota-control plugin which will be fully supported Mitsubishi AC devices locally and bridged it to the HomeKit.

Related issue (if applicable): fixes #

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.8
  • The code change is tested and works with Tasmota core ESP32 V.3.1.0.240926
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@grzegorz914
Update xdrv_44_miel_hvac.ino
45f813d 
Code structure cleanup,
Add Power, SetTemperature, Mode, SwingV, SwingH, FanSpeed to JSON StatusSNS MiElHVAC
@grzegorz914
Update xdrv_44_miel_hvac.ino
db679ad
@grzegorz914
clesnup
6d8d8ca
@grzegorz914 grzegorz914 mentioned this pull request Oct 4, 2024
Open
@grzegorz914
Copy link
Contributor Author

grzegorz914 commented Oct 4, 2024 •
edited
Loading

@arendst
ready for review

Thanks
Grzegorz

@Jason2866
Copy link
Collaborator

@grzegorz914 Plese undo format & style changes

@Jason2866 Jason2866 marked this pull request as draft October 4, 2024 17:38
@grzegorz914 grzegorz914 marked this pull request as ready for review October 4, 2024 19:35
@grzegorz914
Copy link
Contributor Author

@Jason2866 ready

@grzegorz914
Copy link
Contributor Author

@arendst @Jason2866
please review and merge this if You have time because I have other PR and add AirDirection control (even, direct, indirect) for devices with ISEE sensor.

@arendst arendst merged commit ba687de into arendst:development Oct 5, 2024
59 checks passed
josef109 pushed a commit to josef109/Tasmota that referenced this pull request Nov 7, 2024
@grzegorz914 @josef109
Bridge Mitsubishi AC devices to Homebridge/Homekit locally (arendst#2…
5a03b05 
…2236)

* Update xdrv_44_miel_hvac.ino

Code structure cleanup,
Add Power, SetTemperature, Mode, SwingV, SwingH, FanSpeed to JSON StatusSNS MiElHVAC

* Update xdrv_44_miel_hvac.ino

* clesnup

* Revert "Update xdrv_44_miel_hvac.ino"

This reverts commit 45f813d.

* revert styling and format

* make operation and compressor indyvidual and remove unnecessary sep

* Update xdrv_44_miel_hvac.ino

* Update xdrv_44_miel_hvac.ino

* Use uppercase
josef109 pushed a commit to josef109/Tasmota that referenced this pull request Nov 10, 2024
@grzegorz914 @josef109
Bridge Mitsubishi AC devices to Homebridge/Homekit locally (arendst#2…
8801f4d 
…2236)

* Update xdrv_44_miel_hvac.ino

Code structure cleanup,
Add Power, SetTemperature, Mode, SwingV, SwingH, FanSpeed to JSON StatusSNS MiElHVAC

* Update xdrv_44_miel_hvac.ino

* clesnup

* Revert "Update xdrv_44_miel_hvac.ino"

This reverts commit 45f813d.

* revert styling and format

* make operation and compressor indyvidual and remove unnecessary sep

* Update xdrv_44_miel_hvac.ino

* Update xdrv_44_miel_hvac.ino

* Use uppercase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arendst arendst arendst left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grzegorz914 @Jason2866 @arendst