Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mcp230xx - Add 1 and 0 as option for ON and OFF #6524

Merged
merged 2 commits into from
Sep 30, 2019
Merged

Mcp230xx - Add 1 and 0 as option for ON and OFF #6524

merged 2 commits into from
Sep 30, 2019

Conversation

andrethomas
Copy link
Contributor

@andrethomas andrethomas commented Sep 30, 2019 •
edited
Loading

MCP230xx - Add 1 and 0 as an option for ON and OFF

Description:

PR #6522 bears reference.

This PR adds the ability to use sensor29 pin,1 and sensor29 pin,0 to substitute sensor29 pin,ON and sensor29 pin,OFF respectively.

Related issue (if applicable): fixes #

Checklist:

  • The pull request is done against the latest dev branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR.
  • The code change is tested and works on core 2.3.0, 2.4.2, 2.5.2, and pre-2.6
  • The code change pass travis tests. Your PR cannot be merged unless tests pass
  • I accept the CLA.

@andrethomas
MCP230xx - Add 1 and 0 as option for ON and OFF
bed26fd 
MCP230xx - Add 1 and 0 as option for ON and OFF
@andrethomas
MCP230xx - Add sensor29 pin,1 and sensor29 pin,0
b38a8bd 
MCP230xx - Add sensor29 pin,1 and sensor29 pin,0 as an alternative to sensor29 pin,ON and sensor29 pin,OFF respectively.
@gemu2015
Copy link
Contributor

@andrethomas
thanks, super fast as usual!

@andrethomas
Copy link
Contributor Author

Just want to check something first :)

@arendst arendst merged commit b850ac1 into arendst:development Sep 30, 2019
@andrethomas andrethomas deleted the mcp230xx branch September 30, 2019 19:25
@andrethomas andrethomas mentioned this pull request Sep 30, 2019
Merged
6 tasks
@effelle
Copy link
Contributor

effelle commented Oct 1, 2019

@andrethomas how about Toggle option?
sensor29 pin,T will be changed to sensor29 pin, 2?

@andrethomas andrethomas mentioned this pull request Oct 1, 2019
Merged
6 tasks
arendst added a commit that referenced this pull request Oct 2, 2019
@arendst
Change command handling
8c34b9e 
 * Change command SetOption43 to make it more general. Now supports PS_16_DZ driver too (#6547)
 * Change command handling by moving buffers up in chain solving MQTTlog support (#6524)
 * Change detection of non-MQTT commands by allowing non-space characters as delimiter (#6540)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrethomas @gemu2015 @effelle @arendst