Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command should be able to end with other characters #6540

Closed
wants to merge 1 commit into from
Closed

Command should be able to end with other characters #6540

wants to merge 1 commit into from

Conversation

laurentdong
Copy link
Contributor

Description:

Without this fix, VAR1=1 does not work becuase a space after a command is required, like: VAR1 =1

Since ExecuteCommand() function has been moved to support_command.ino, so the auto merging did not merge pull request 5433 properly -- missed some code.

Related issue (if applicable): #5433

Checklist:

  • The pull request is done against the latest dev branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR.
  • The code change is tested and works on core 2.3.0, 2.4.2, 2.5.2, and pre-2.6
  • The code change pass travis tests. Your PR cannot be merged unless tests pass
  • I accept the CLA.

@laurentdong
Command should be able to end with other characters
3d9ef06 
Merging of pull request arendst#5433 missed some code.
arendst added a commit that referenced this pull request Oct 2, 2019
@arendst
Change command handling
8c34b9e 
 * Change command SetOption43 to make it more general. Now supports PS_16_DZ driver too (#6547)
 * Change command handling by moving buffers up in chain solving MQTTlog support (#6524)
 * Change detection of non-MQTT commands by allowing non-space characters as delimiter (#6540)
@arendst
Copy link
Owner

arendst commented Oct 2, 2019

Implemented in a slightly different form just now.

@arendst arendst closed this Oct 2, 2019
@laurentdong laurentdong deleted the PR#5433 branch October 2, 2019 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laurentdong @arendst