Skip to content

Commit

Permalink
chore: some integ tests fail because two synths have different output (
Browse files Browse the repository at this point in the history
…aws#22411)

We added salting of asset hashes to the integ tests, but got the scope wrong: the salt used to be unique per CDK app synth, but some integ tests synth multiple times and compare the outputs.

Make the salt unique per run of the tests instead.

Fixes the pipeline.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
rix0rrr authored and arewa committed Oct 8, 2022
1 parent 60e352d commit d740b55
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/aws-cdk/test/integ/cli/app/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,7 @@ class BuiltinLambdaStack extends cdk.Stack {

const app = new cdk.App({
context: {
'@aws-cdk/core:assetHashSalt': `${Date.now()}`, // Force all assets to be unique
'@aws-cdk/core:assetHashSalt': process.env.CODEBUILD_BUILD_ID, // Force all assets to be unique, but consistent in one build
},
});

Expand Down

0 comments on commit d740b55

Please sign in to comment.