Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: some integ tests fail because two synths have different output #22411

Merged
merged 2 commits into from
Oct 7, 2022

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Oct 7, 2022

We added salting of asset hashes to the integ tests, but got the scope wrong: the salt used to be unique per CDK app synth, but some integ tests synth multiple times and compare the outputs.

Make the salt unique per run of the tests instead.

Fixes the pipeline.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

We added salting of asset hashes to the integ tests, but got the scope
wrong: the salt used to be unique per CDK app synth, but some integ
tests synth multiple times and compare the outputs.

Make the salt unique per run of the tests instead.

Fixes the pipeline.
@rix0rrr rix0rrr requested a review from a team October 7, 2022 08:48
@rix0rrr rix0rrr self-assigned this Oct 7, 2022
@gitpod-io
Copy link

gitpod-io bot commented Oct 7, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team October 7, 2022 08:48
@github-actions github-actions bot added the p2 label Oct 7, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 7, 2022
Copy link
Contributor

@Naumel Naumel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩹

@mergify
Copy link
Contributor

mergify bot commented Oct 7, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b8b4e0b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit f01c842 into main Oct 7, 2022
@mergify mergify bot deleted the huijbers/consistent-assets branch October 7, 2022 10:09
@mergify
Copy link
Contributor

mergify bot commented Oct 7, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

arewa pushed a commit to arewa/aws-cdk that referenced this pull request Oct 8, 2022
…aws#22411)

We added salting of asset hashes to the integ tests, but got the scope wrong: the salt used to be unique per CDK app synth, but some integ tests synth multiple times and compare the outputs.

Make the salt unique per run of the tests instead.

Fixes the pipeline.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
homakk pushed a commit to homakk/aws-cdk that referenced this pull request Dec 1, 2022
…aws#22411)

We added salting of asset hashes to the integ tests, but got the scope wrong: the salt used to be unique per CDK app synth, but some integ tests synth multiple times and compare the outputs.

Make the salt unique per run of the tests instead.

Fixes the pipeline.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants