This repository has been archived by the owner on Jun 14, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9
feat: migrate POST /api/workspaces/:workspace_id/users
to API v1
#156
Merged
jfcalvo
merged 10 commits into
feat/move-api-v0-functionality-to-v1
from
feat/migrate-create-workspace-users-to-api-v1
May 13, 2024
Merged
feat: migrate POST /api/workspaces/:workspace_id/users
to API v1
#156
jfcalvo
merged 10 commits into
feat/move-api-v0-functionality-to-v1
from
feat/migrate-create-workspace-users-to-api-v1
May 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…workspaces/:workspace_id/users
jfcalvo
changed the title
feat: migrate creation of workspace users to API v1
feat: migrate May 8, 2024
POST /api/workspaces/:workspace_id/users
to API v1
frascuchon
reviewed
May 10, 2024
frascuchon
reviewed
May 10, 2024
frascuchon
reviewed
May 13, 2024
@@ -21,6 +21,12 @@ class NotFoundError(Exception): | |||
pass | |||
|
|||
|
|||
class NotUniqueError(Exception): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
frascuchon
approved these changes
May 13, 2024
Base automatically changed from
feat/migrate-list-workspace-users-to-api-v1
to
feat/move-api-v0-functionality-to-v1
May 13, 2024 10:25
…-create-workspace-users-to-api-v1
jfcalvo
merged commit May 13, 2024
a21e75d
into
feat/move-api-v0-functionality-to-v1
10 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add a new endpoint
POST /api/v1/workspaces/:workspace_id/users
to create a new user for a workspace.Changes introduced in this new endpoint compared to the old one:
user_id
in the body of thePOST
request instead of adding it in the URL.create_workspace_user
context function so we need an additional change inargilla
repo. The PR with the changes on argilla is here: feat: changes related with migrating endpoints from API v0 to API v1 argilla#4807full_name
orworkspaces
.Closes #155
Type of change
(Please delete options that are not relevant. Remember to title the PR according to the type of change)
How Has This Been Tested
Checklist