feat: changes related with migrating endpoints from API v0 to API v1 #4807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
15 tasks
jfcalvo
added a commit
to argilla-io/argilla-server
that referenced
this pull request
May 13, 2024
) # Description This PR add a new endpoint `POST /api/v1/workspaces/:workspace_id/users` to create a new user for a workspace. Changes introduced in this new endpoint compared to the old one: * Now we must provide the `user_id` in the body of the `POST` request instead of adding it in the URL. * I have changed the `create_workspace_user` context function so we need an additional change in `argilla` repo. The PR with the changes on argilla is here: argilla-io/argilla#4807 * As done with previous PRs the returned user doesn't has `full_name` or `workspaces`. Closes #155 **Type of change** (Please delete options that are not relevant. Remember to title the PR according to the type of change) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Refactor (change restructuring the codebase without changing functionality) - [ ] Improvement (change adding some improvement to an existing functionality) - [ ] Documentation update **How Has This Been Tested** - [x] Adding new tests for the endpoint. **Checklist** - [ ] I added relevant documentation - [ ] follows the style guidelines of this project - [ ] I did a self-review of my code - [ ] I made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK) (see text above) - [ ] I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)
|
These changes were already added on PR: #4826 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a PR grouping all the changes needed on
argillarepo related with changes onargilla-servermigrating endpoints from API v0 to API v1.Warning
This PR should be only merged once we merge the migration changes on argilla-server repository.
Closes #4806
Type of change
(Please delete options that are not relevant. Remember to title the PR according to the type of change)
How Has This Been Tested
(Please describe the tests that you ran to verify your changes. And ideally, reference
tests)Checklist