Skip to content

Commit

Permalink
fix(#1015): manage emojis in Token Classification records (#1016)
Browse files Browse the repository at this point in the history
This PR includes external library for manage emojis that are represented by several characters and cause annotation errors

Closes #1015
  • Loading branch information
leiyre authored Jan 21, 2022
1 parent 176e48a commit dda1bd2
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 5 deletions.
7 changes: 5 additions & 2 deletions frontend/components/token-classifier/results/TextSpan.vue
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@
import ClickOutside from "v-click-outside";
import "assets/icons/check";
import "assets/icons/cross";
import { substring } from "stringz";

export default {
directives: {
Expand Down Expand Up @@ -113,13 +114,15 @@ export default {
return this.spans[this.spanId];
},
text() {
return this.record.raw_text.slice(
return substring(
this.record.raw_text,
this.spans[this.spanId].start,
this.spans[this.spanId].end
);
},
whiteSpace() {
return this.record.raw_text.slice(
return substring(
this.record.raw_text,
this.spans[this.spanId].end,
this.spans[this.spanId + 1] ? this.spans[this.spanId + 1].start : ""
);
Expand Down
5 changes: 3 additions & 2 deletions frontend/models/TokenClassification.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

import { ObservationDataset, USER_DATA_METADATA_KEY } from "./Dataset";
import { BaseRecord, BaseSearchQuery, BaseSearchResults } from "./Common";
import { indexOf, length } from "stringz";

class TokenClassificationRecord extends BaseRecord {
tokens;
Expand All @@ -28,8 +29,8 @@ class TokenClassificationRecord extends BaseRecord {
super({ ...superData });
const { visualTokens } = tokens.reduce(
({ visualTokens, startPosition }, token) => {
const start = raw_text.indexOf(token, startPosition);
const end = start + token.length;
const start = indexOf(raw_text, token, startPosition);
const end = start + length(token);
return {
visualTokens: [...visualTokens, { start, end, text: token }],
startPosition: end,
Expand Down
3 changes: 2 additions & 1 deletion frontend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
"nuxt": "^2.14.6",
"nuxt-highlightjs": "^1.0.1",
"sass-loader": "^10.1.0",
"stringz": "^2.1.0",
"v-click-outside": "^3.1.2",
"vue-moment": "^4.1.0",
"vue-svgicon": "^3.2.9",
Expand All @@ -59,4 +60,4 @@
"prettier": "^2.2.1",
"vue-jest": "^3.0.7"
}
}
}

0 comments on commit dda1bd2

Please sign in to comment.