Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#1015): manage emojis in Token Classification records #1016

Merged
merged 2 commits into from
Jan 21, 2022

Conversation

leiyre
Copy link
Member

@leiyre leiyre commented Jan 21, 2022

fix(#1015)
This PR includes external library for manage emojis that are represented by several characters and cause annotation errors

fix(#1015)
This PR includes external library for manage emojis that are represented by several characters and cause annotation errors
@leiyre leiyre requested a review from frascuchon January 21, 2022 13:29
@codecov
Copy link

codecov bot commented Jan 21, 2022

Codecov Report

Merging #1016 (168dda0) into master (1416700) will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1016      +/-   ##
==========================================
- Coverage   95.49%   95.36%   -0.14%     
==========================================
  Files         110      110              
  Lines        4239     4248       +9     
==========================================
+ Hits         4048     4051       +3     
- Misses        191      197       +6     
Flag Coverage Δ
pytest 95.36% <ø> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/rubrix/server/commons/static_rewrite.py 44.44% <0.00%> (-11.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1416700...168dda0. Read the comment docs.

@frascuchon frascuchon added app type: bug Indicates an unexpected problem or unintended behavior labels Jan 21, 2022
@frascuchon frascuchon merged commit dda1bd2 into master Jan 21, 2022
@frascuchon frascuchon deleted the fix/manage_emojis branch January 21, 2022 17:48
dvsrepo added a commit that referenced this pull request Jan 25, 2022
* 'master' of https://github.com/recognai/rubrix: (28 commits)
  chore(#994): simplify server start (#1014)
  refactor(#945): elasticsearch index configuration per task (#1018)
  docs(#980): Add majorityvote example to weak supervision guide (#1004)
  fix(#1015): manage emojis in Token Classification records (#1016)
  fix(#1010): fix WeakLabels when not providing rules (#1011)
  fix(Breadcrumbs): Copy text function (#1003)
  fix(statics): handle 404 errors for static files (#1006)
  refactor: Rename 'exclude_missing_annotation' argument for WeakLabels.annotation (#1005)
  docs: update video for spacy ner tutorial (#1000)
  fix(#977) Remove redirection when accessing login (#996)
  feat(#951): new uncovered_by_rules records filter (#991)
  feat(#735): add warning when agent but no prediction/annotation is provided (#987)
  fix(#800): limit number of metadata fields (#993)
  docs: improve annotate records section in web app reference (#985)
  fix(#844) Keep header layout when errors occurred in dataset view (#992)
  fix(#974): display the dropdown in the last record of the scroll (#986)
  refactor: compute common aggregations one by one (#990)
  feat(#953): add additional metrics to `LabelModel.score` method (#979)
  refactor(rules): using labeling rules management with vuex store (#878)
  feat(#955): add default for `rules` in WeakLabels (#976)
  ...
frascuchon pushed a commit that referenced this pull request Jan 31, 2022
This PR includes external library for manage emojis that are represented by several characters and cause annotation errors

Closes #1015

(cherry picked from commit dda1bd2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants