Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Define rules] Affected records count should be shown with selected label #872

Closed
frascuchon opened this issue Jan 4, 2022 · 0 comments · Fixed by #875
Closed

[Define rules] Affected records count should be shown with selected label #872

frascuchon opened this issue Jan 4, 2022 · 0 comments · Fixed by #875
Assignees
@dvsrepo @leiyre @Amelie-V
Labels
type: bug Indicates an unexpected problem or unintended behavior

Comments

@frascuchon
Copy link
Member

Affected records count (Records: ...) should be shown only if we have label info. Otherwise, it's quite confusing:

Screenshot 2022-01-03 at 14 47 25

The same could be applied to coverage and annotated coverage (Giving 0% of coverage while rule query returns results is confusing)
@frascuchon frascuchon added type: bug Indicates an unexpected problem or unintended behavior app labels Jan 4, 2022
leiyre pushed a commit that referenced this issue Jan 4, 2022
fix(UI) Metrics value by default if no metric
6c4833b 
fix #872
@leiyre leiyre mentioned this issue Jan 4, 2022
Merged
frascuchon pushed a commit that referenced this issue Jan 4, 2022
fix(UI) Metrics value by default if no metric (#875)
70928b7 
* fix(UI) Metrics value by default if no metric

fix #872

* precision and correct metric default value

* update metrics when removing label

* chore: format method

* lint fix

Co-authored-by: Francisco Aranda <francisco@recogn.ai>
frascuchon pushed a commit that referenced this issue Jan 11, 2022
fix(UI) Metrics value by default if no metric (#875)
2dfb523 
* fix(UI) Metrics value by default if no metric

fix #872

* precision and correct metric default value

* update metrics when removing label

* chore: format method

* lint fix

Co-authored-by: Francisco Aranda <francisco@recogn.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dvsrepo dvsrepo

@leiyre leiyre

@Amelie-V Amelie-V

Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(UI) Metrics value by default if no metric argilla-io/argilla
4 participants
@dvsrepo @frascuchon @leiyre @Amelie-V