Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(UI) Metrics value by default if no metric #875

Merged
merged 5 commits into from
Jan 4, 2022
Merged

fix(UI) Metrics value by default if no metric #875

merged 5 commits into from
Jan 4, 2022

Conversation

leiyre
Copy link
Member

@leiyre leiyre commented Jan 4, 2022

fix #872

@leiyre leiyre requested a review from frascuchon January 4, 2022 12:54
@codecov
Copy link

codecov bot commented Jan 4, 2022 •
edited
Loading

Codecov Report

Merging #875 (35c927f) into master (d6a32dc) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 35c927f differs from pull request most recent head d046182. Consider uploading reports for the commit d046182 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #875      +/-   ##
==========================================
+ Coverage   95.48%   95.50%   +0.01%     
==========================================
  Files         109      109              
  Lines        4190     4202      +12     
==========================================
+ Hits         4001     4013      +12     
  Misses        189      189
Flag Coverage Δ
pytest 95.50% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ubrix/server/tasks/token_classification/metrics.py 99.41% <0.00%> (ø)
src/rubrix/metrics/token_classification/metrics.py 97.26% <0.00%> (+0.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6a32dc...d046182. Read the comment docs.

@frascuchon frascuchon merged commit 70928b7 into master Jan 4, 2022
@frascuchon frascuchon deleted the ui/define_rules_records_count_default branch January 4, 2022 15:18
dvsrepo added a commit that referenced this pull request Jan 11, 2022
@dvsrepo
Merge branch 'master' of https://github.com/recognai/rubrix
2adcf12 
* 'master' of https://github.com/recognai/rubrix:
  Docs: Updates Flair zeroshot tutorial (#887)
  removing wrong video (#885)
  Update readme (#883)
  fix(UI) Metrics value by default if no metric (#875)
  feat(metrics): add token level metrics for token classification from client (#849)
  UI: New rule metrics layout (#861)
  chore: expose load_rules from base module (#866)
frascuchon pushed a commit that referenced this pull request Jan 11, 2022
fix(UI) Metrics value by default if no metric (#875)
2dfb523 
* fix(UI) Metrics value by default if no metric

fix #872

* precision and correct metric default value

* update metrics when removing label

* chore: format method

* lint fix

Co-authored-by: Francisco Aranda <francisco@recogn.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frascuchon frascuchon frascuchon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Define rules] Affected records count should be shown with selected label
2 participants
@leiyre @frascuchon