Create output_folder using os.makedirs() #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove get_storage() and create_namespace() calls that were used to create output_folder, those calls only work if the storage class happens to be posix. If the class is S3, then storage_root is a bucket and create_namespace() is a no-op, so the output_folder directory does not get created. Since the logs are all posix-based, use os.makedirs() to create output_folder. Also move the basicConfig() call to the point after where the previous dlio.log file has been deleted so that log messages don't go to an unlinked file. Move a message that was issued before the prior log was deleted to a spot after where the new log has been configured.
zhenghh04
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove get_storage() and create_namespace() calls that were used to create output_folder, those calls only work if the storage class happens to be posix. If the class is S3, then storage_root is a bucket and create_namespace() is a no-op, so the output_folder directory does not get created. Since the logs are all posix-based, use os.makedirs() to create output_folder. Also move the basicConfig() call to the point after where the previous dlio.log file has been deleted so that log messages don't go to an unlinked file. Move a message that was issued before the prior log was deleted to a spot after where the new log has been configured.