Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create output_folder using os.makedirs() #124

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Create output_folder using os.makedirs() #124

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d7c6c5
Create output_folder using os.makedirs()
krehm Dec 8, 2023
234cbfb
Update main.py to restore self.output_folder argument
zhenghh04 Dec 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 18 additions & 19 deletions dlio_benchmark/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,33 +69,19 @@ def __init__(self, cfg):
t0 = time()
self.args = ConfigArguments.get_instance()
LoadConfig(self.args, cfg)
self.storage = StorageFactory().get_storage(self.args.storage_type, self.args.storage_root,
self.args.framework)

if self.args.output_folder is None:
try:
hydra_cfg = hydra.core.hydra_config.HydraConfig.get()
self.args.output_folder = hydra_cfg['runtime']['output_dir']
except:
self.args.output_folder = 'output/'
self.output_folder = self.args.output_folder
self.storage = StorageFactory().get_storage(self.args.storage_type, self.args.storage_root,
self.args.framework)
self.output_folder = self.args.output_folder
self.output = StorageFactory().get_storage(self.args.storage_type, self.args.output_folder,
self.args.framework)
self.output.create_namespace(exist_ok=True)
self.logfile = os.path.join(self.output_folder, self.args.log_file)
# Configure the logging library
log_level = logging.DEBUG if self.args.debug else logging.INFO
logging.basicConfig(
level=log_level,
handlers=[
logging.FileHandler(self.logfile, mode="a", encoding='utf-8'),
logging.StreamHandler()
],
format='[%(levelname)s] %(message)s [%(pathname)s:%(lineno)d]'
# logging's max timestamp resolution is msecs, we will pass in usecs in the message
)
os.makedirs(self.args.output_folder, mode=0o755, exist_ok=True)
self.logfile = os.path.join(self.args.output_folder, self.args.log_file)
dlp_trace = get_trace_name(self.args.output_folder)
logging.info(f"{utcnow()} Profiling DLIO {dlp_trace}")
self.dlp_logger = PerfTrace.initialize_log(logfile=dlp_trace,
data_dir=f"{os.path.abspath(self.args.data_folder)}:{self.args.data_folder}:./{self.args.data_folder}",
process_id=get_rank())
Expand All @@ -114,7 +100,20 @@ def __init__(self, cfg):
if os.path.isfile(self.logfile):
os.remove(self.logfile)
self.framework.barrier()
# Configure the logging library
log_level = logging.DEBUG if self.args.debug else logging.INFO
logging.basicConfig(
level=log_level,
force=True,
handlers=[
logging.FileHandler(self.logfile, mode="a", encoding='utf-8'),
logging.StreamHandler()
],
format='[%(levelname)s] %(message)s [%(pathname)s:%(lineno)d]'
# logging's max timestamp resolution is msecs, we will pass in usecs in the message
)
if self.args.my_rank == 0:
logging.info(f"{utcnow()} Profiling DLIO {dlp_trace}")
logging.info(f"{utcnow()} Running DLIO with {self.args.comm_size} process(es)")
try:
logging.info(
Expand Down