Add Support for sidecar and init containers in Argo CD CRD for App Controller and API server #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svghadi
reviewed
Jul 24, 2024
|
I am yet to test it locally, but it looks good. The unit test coverage is solid. Do you think we need an additional e2e kuttl test? |
|
Ran some local tests. Looks good. I was wondering if we should include support for |
iam-veeramalla
force-pushed
the
sidecarsupport
branch
from
44506d3 to
0d5eb16
Compare
svghadi
requested changes
Jul 31, 2024
svghadi
approved these changes
Jul 31, 2024
Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
iam-veeramalla
force-pushed
the
sidecarsupport
branch
from
9b30aac to
07be6bd
Compare
Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
iam-veeramalla
force-pushed
the
sidecarsupport
branch
from
dd10891 to
306238a
Compare
svghadi
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do / why we need it:
Fixes #1476
Closes #1476
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #1476
How to test changes / Special notes to the reviewer:
TestReconcileServer_InitContainersTestReconcile_SidecarContainersTestReconcileAppController_InitcontainerTestReconcileArgoCD_sidecarcontainer